Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multiphase Hybrid - FY24 Q2 milestone (sharpening the pressure field) #1099

Merged
merged 47 commits into from
Jul 22, 2024

Conversation

mbkuhn
Copy link
Contributor

@mbkuhn mbkuhn commented Jun 11, 2024

Summary

This PR enables the pressure field from Nalu-Wind to be modified according to the sharpening of the interface via terms applied to the pressure gradient.

Pull request type

Please check the type of change introduced:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

The following is included:

  • new unit-test(s)
  • new regression test(s)
  • documentation for new capability

This PR was tested by running:

  • the unit tests
    • on GPU
    • on CPU
  • the regression tests
    • on GPU
    • on CPU

Additional background

This should be accompanied with new unit tests; the reg tests will be in the exawind-driver repo. More checking and refinement to come; I wanted to put it out there. To follow the merging of #1065

@mbkuhn mbkuhn force-pushed the mphase_hybrid_overset_ops2 branch from 453ec3c to 1771c5d Compare July 10, 2024 15:02
@mbkuhn mbkuhn marked this pull request as ready for review July 18, 2024 21:37
@mbkuhn mbkuhn requested a review from marchdf July 18, 2024 22:05
Copy link
Contributor

@marchdf marchdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!! Just some minor stuff.

amr-wind/overset/OversetOps.cpp Outdated Show resolved Hide resolved
amr-wind/overset/OversetOps.cpp Outdated Show resolved Hide resolved
amr-wind/overset/OversetOps.cpp Outdated Show resolved Hide resolved
amr-wind/overset/overset_ops_K.H Outdated Show resolved Hide resolved
amr-wind/overset/overset_ops_K.H Outdated Show resolved Hide resolved
amr-wind/overset/overset_ops_routines.cpp Show resolved Hide resolved
amr-wind/overset/overset_ops_routines.cpp Outdated Show resolved Hide resolved
amr-wind/overset/overset_ops_routines.cpp Outdated Show resolved Hide resolved
amr-wind/overset/overset_ops_routines.cpp Outdated Show resolved Hide resolved
unit_tests/multiphase/test_vof_overset_ops.cpp Outdated Show resolved Hide resolved
@mbkuhn mbkuhn requested a review from marchdf July 22, 2024 21:37
@mbkuhn mbkuhn merged commit fe73b70 into Exawind:main Jul 22, 2024
13 checks passed
@mbkuhn mbkuhn deleted the mphase_hybrid_overset_ops2 branch July 25, 2024 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants